Make it clearer that edition functions are >=, not ==
#113765
Merged
+46
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This seems way more reasonable to me. |
|
Nils is /afk |
oli-obk
requested changes
Jul 19, 2023
compiler/rustc_span/src/lib.rs
Outdated
| } | ||
|
|
||
| /// Are we allowed to use features from the Rust 2018 edition? |
There was a problem hiding this comment.
Suggested change
| /// Are we allowed to use features from the Rust 2018 edition? | |
| /// Are we allowed to use features from the Rust 2021 edition? |
compiler/rustc_span/src/lib.rs
Outdated
| } | ||
|
|
||
| /// Are we allowed to use features from the Rust 2018 edition? |
There was a problem hiding this comment.
Suggested change
| /// Are we allowed to use features from the Rust 2018 edition? | |
| /// Are we allowed to use features from the Rust 2024 edition? |
oli-obk
added
S-waiting-on-author
rust-cloud-vms
bot
force-pushed
the
at-least
branch
from
163d253 to
846cc63
Compare
|
@bors r=oli-obk rollup (naming only) |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 19, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#113444 (add tests for alias bound preference) - rust-lang#113716 (Add the `no-builtins` attribute to functions when `no_builtins` is applied at the crate level.) - rust-lang#113754 (Simplify native_libs query) - rust-lang#113765 (Make it clearer that edition functions are `>=`, not `==`) - rust-lang#113774 (Improve error message when closing bracket interpreted as formatting fill character) - rust-lang#113785 (Fix invalid display of inlined re-export when both local and foreign items are inlined) - rust-lang#113803 (Fix inline_const with interpolated block) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Nilstrieb
We could also perhaps derive
OrdonEditionand use comparison operators.